Blocks: Update '__experimentalHasContentRoleAttribute' deprecation #65616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Blocks
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -3 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
youknowriad
approved these changes
Sep 24, 2024
|
Thanks for the follow-up |
Mamaduka
added
the
Backport to WP 6.7 Beta/RC
|
Flaky tests detected in f092c92. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11014594053
|
|
There was a conflict while trying to cherry-pick the commit to the wp/6.7 branch. Please resolve the conflict manually and create a PR to the wp/6.7 branch. PRs to wp/6.7 are similar to PRs to trunk, but you should base your PR on the wp/6.7 branch instead of trunk. |
|
Thanks for this. I thought we'd (collectively) agreed in the PR that was the way to play it. My mistake. |
|
That's useful context. Thanks 👍 |
noisysocks
pushed a commit
that referenced
this pull request
Sep 30, 2024
…65616) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
noisysocks
pushed a commit
that referenced
this pull request
Sep 30, 2024
…65616) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
noisysocks
added
Backported to WP Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #65484.
PR removes alternative suggestion from
__experimentalHasContentRoleAttributeselector deprecation.Why?
The suggested alternative is a private API. Public API deprecations shouldn't recommend private APIs, as they make deprecation unactionable for consumers.
Testing Instructions
None.