Only show zoom out inserters on block selection #65759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +399 B (+0.02%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
This was referenced Oct 1, 2024
getdave
pushed a commit
that referenced
this pull request
Oct 1, 2024
Removes code related to showing/hiding inserters on hover.
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
Removes code related to showing/hiding inserters on hover.
huubl
added a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
)" This reverts commit 6641b29.
draganescu
pushed a commit
that referenced
this pull request
Oct 2, 2024
Removes code related to showing/hiding inserters on hover.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #65754 and #65756
What?
Removes zoom out mode inserters from showing when hovering. Only show them when the block is selected.
Why?
See #65754
How?
Removes hover-related show/hiding from zoom out mode inserter code. I looked at the PR that added this functionality and removed code related to showing the inserters on hover.
Testing Instructions
Testing Instructions for Keyboard
Test that you can still use arrow keys to navigate the block canvas and that the zoom out mode inserters show and are keyboard accessible
Screenshots or screencast
Screen.Recording.2024-09-30.at.2.21.54.PM.mov