Update/replace edit button with enter on selection #65760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -18 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Rebased. |
jeryj
force-pushed
the
update/replace-edit-button-with-enter-on-selection
branch
from
c6afb69
to
2ef6b8c
Compare
jeryj
force-pushed
the
update/replace-edit-button-with-enter-on-selection
branch
from
2ef6b8c
to
fd9a985
Compare
|
@richtabor - I like this interaction at the moment. What do you think? |
MaggieCabrera
approved these changes
Oct 4, 2024
|
Talked with @richtabor and he confirmed the behavior was good to ship for now. |
|
@getdave @jeryj and @MaggieCabrera, was this intended to be included in WP 6.7? I was chatting with @tellthemachines who noticed the behaviour in the Before video is currently in WP 6.7 Beta 3, so just thought to check in case it was missed for backporting. It's labelled as an enhancement, so wasn't too sure. |
|
I would say this should be included but I'll defer to @jeryj for final confirmation. Thank you for spotting. |
|
I'd consider this a fix suitable for 6.7. |
jeryj
added
the
Backport to WP 6.7 Beta/RC
|
Yup! This should have been backported. Thanks for noticing! |
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 16, 2024
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 930b9e6 |
|
Thanks folks! 🙇 |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Removes edit button from zoom out mode toolbar and replaces it with an enter keypress on the selected block while in zoom out mode.
Why?
Fixes #65746. Also, currently pressing Enter on the selected block will add a paragraph block, which does not seem like the intended behavior in this view.How?
Adds condition to existing
useSelectedBlockEventHandlersEnter keypress to exit zoom out if an enter keypress on selected block in zoom out mode.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
Screen.Recording.2024-10-01.at.2.15.36.PM.mov
After
Screen.Recording.2024-10-01.at.2.14.53.PM.mov