Hide Zoom Out Inserters when dragging into canvas #65789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Bug
getdave
commented
Oct 1, 2024
| @@ -34,7 +34,8 @@ function selector( select ) { | |||
| getSettings, | |||
| __unstableGetEditorMode, | |||
| isTyping, | |||
| } = select( blockEditorStore ); | |||
| isDragging, | |||
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +21 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
talldan
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Looks good, nice improvement.
There's one small thing that I noticed that could still be improved. If you cancel the drag by dragging back to the inserter and releasing, the blue inserter button reappears and the gray insertion zone doesn't hide until hovering over the canvas:
Kapture.2024-10-01.at.16.24.04.mp4
Could be a follow up as it's more of an edge case.
|
Thanks @talldan!
Ah yes. I think I know why. I will try and fix that in a followup as it's likely to be fairly complex. |
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
Co-authored-by: getdave <get_dave@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org>
huubl
added a commit
to huubl/gutenberg
that referenced
this pull request
Oct 2, 2024
This reverts commit 9a16053.
draganescu
pushed a commit
that referenced
this pull request
Oct 2, 2024
Co-authored-by: getdave <get_dave@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Hides the Zoom Out inserters when dragging blocks into the canvas in Zoom Out mode.
Closes #65748
Why?
See #65748. It looks messy and overlaps occur.
How?
Conditionally render the inserters when
isDraggingstate istrue.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Capture.on.2024-10-01.at.14-35-09.mp4