Block Bindings: Accept client ID as parameter for useBlockBindingsUtils
#65818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
[Type] Bug
|
Size Change: +1 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
64 tasks
gziolo
reviewed
Oct 9, 2024
|
|
||
| let clientId; | ||
| beforeEach( async () => { | ||
| const block = createBlock( 'core/paragraph', { |
There was a problem hiding this comment.
Super nuanced nit. I believe that you can use here dispatch( blockEditorStore ).resetBlocks( [ block ] ); instead of insertBlocks.
This way dispatch( blockEditorStore ).resetBlocks( [] ); could be run only once in afterAll instead of afterEach.
There was a problem hiding this comment.
That's a good one 🙂 If I understood you correctly, it has been addressed in this commit: e52bab2
gziolo
approved these changes
Oct 9, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Because I didn't have time to properly review it after pushing and then I forgot to mark it as ready 😄 I have just done that and addressed the comment. |
|
Flaky tests detected in e52bab2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11256712589
|
cbravobernal
deleted the
fix/pass-client-id-to-use-block-bindings-utils
branch
|
There was a conflict while trying to cherry-pick the commit to the wp/6.7 branch. Please resolve the conflict manually and create a PR to the wp/6.7 branch. PRs to wp/6.7 are similar to PRs to trunk, but you should base your PR on the wp/6.7 branch instead of trunk. |
kevin940726
pushed a commit
that referenced
this pull request
Oct 11, 2024
…ils` (#65818) * Pass `clientId` to `useBlockBindingsUtils` * Add unit tests for `useBlockBindingsUtils` * Use `resetBlocks` instead of `insertBlocks` in unit test Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org>
kevin940726
pushed a commit
that referenced
this pull request
Oct 11, 2024
…ils` (#65818) * Pass `clientId` to `useBlockBindingsUtils` * Add unit tests for `useBlockBindingsUtils` * Use `resetBlocks` instead of `insertBlocks` in unit test Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org>
kevin940726
pushed a commit
that referenced
this pull request
Oct 14, 2024
…ils` (#65818) * Pass `clientId` to `useBlockBindingsUtils` * Add unit tests for `useBlockBindingsUtils` * Use `resetBlocks` instead of `insertBlocks` in unit test Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org>
kevin940726
added
Backported to WP Core
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…ils` (WordPress#65818) * Pass `clientId` to `useBlockBindingsUtils` * Add unit tests for `useBlockBindingsUtils` * Use `resetBlocks` instead of `insertBlocks` in unit test Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org> Co-authored-by: gziolo <gziolo@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
As discussed here, I'm adding the possibility of passing a
clientIdtouseBlockBindingsUtilsinstead of always relying on the edit context.Additionally, I added a few unit tests to cover the different use cases.
Why?
It is a common pattern in other APIs and it is missing in this one.
How?
I added some logic to rely on the parameter and, if it isn't provided, use the client ID returned by
useBlockEditContext.Apart from that, I added unit tests.
Testing Instructions
It is a bit hard to test this manually because code needs to run inside a component or a hook. I added unit tests to cover the different use cases. Additionally, post meta and pattern overrides are using these utils and are covered with e2e tests.