feat: Show block remove button for empty (paragraph) block #6589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No objections. Don't love it, but I'm amenable to the arguments for having it — consistency definitely is key. 👍 👍 Should we revisit the recent icons on the right of the appender? I like them and use them — but we do have a lot of icons. Could we reduce that to two? |
|
Yes, 2 makes more sense, what about three dots and dropdown? Is it useful for empy block? |
If the end goal is consistency, seems like we should keep that, especially if the ellipsis could be made extensible. |
gziolo
added
[Feature] Writing Flow
|
Probably good to wait for Tammie's final call, though! |
|
And confirmation that we want one block icon less :) |
karmatosed
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows the options and remove buttons on the right side for empty (paragraph) blocks.
Fix #6579.
Description
Allow users to remove empty paragraph blocks using visual tools/mouse by clicking the remove button.
I also renamed a variable for extra clarity because it confused me when reading through the code.
How has this been tested?
Tested in browser (Firefox and Chrome); screenshot attached.
Screenshots
Types of changes
Feature simply enables the toolbar for all components, not special-casing the empty paragraph.
Checklist: