-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport #65772 to 6.7 #65905
Backport #65772 to 6.7 #65905
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this backport sorted while I was AFK @ciampo 🚀
I've given this another test and it is working as advertised for me also. The only minor difference I spotted compared to the original PR was in the components changelog and I've left an inline comment there.
All in all, LGTM 🚢
* First pass at deduping palette element slugs. * Addressing TypeScript errors where PaletteEditListViewProps is using a generic type parameter. The linter was complaining that I wasn't doing the same, even though I was using the same inherited types. Whatever. It could probably be optimized, but it's unrelated to the scope of this PR * Add changelog * Make use of PaletteElement type consistent * Address feedback on deduplicate util * Use count rather than index for new slugs --------- Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
Thank you for taking care of all this, everyone! |
Manually fix conflicts (in the CHANGELOG) and backport #65772 to the 6.7 release as agreed with @aaronrobertshaw in #65772 (comment)