-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pattern block: Ensure consistent editing of overrides in Write mode (attempt 2) #66025
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
An existing feature does not function as intended
[Feature] Synced Patterns
Related to synced patterns (formerly reusable blocks)
labels
Oct 10, 2024
Size Change: -92 B (-0.01%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
talldan
changed the title
Reapply "Pattern block: Ensure consistent editing of overrides in Write mode
Pattern block: Ensure consistent editing of overrides in Write mode
Oct 10, 2024
talldan
changed the title
Pattern block: Ensure consistent editing of overrides in Write mode
Pattern block: Ensure consistent editing of overrides in Write mode (attempt 2)
Oct 10, 2024
talldan
force-pushed
the
fix/pattern-blocks-in-write-mode-again-v2
branch
2 times, most recently
from
October 10, 2024 15:23
317aba6
to
ff4e679
Compare
Flaky tests detected in ff4e679. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11277112059
|
talldan
force-pushed
the
fix/pattern-blocks-in-write-mode-again-v2
branch
from
October 14, 2024 12:51
3b69b8a
to
f002066
Compare
talldan
force-pushed
the
fix/pattern-blocks-in-write-mode-again-v2
branch
from
November 11, 2024 07:31
cd0a869
to
b4f2fd3
Compare
talldan
force-pushed
the
fix/pattern-blocks-in-write-mode-again-v2
branch
from
November 11, 2024 07:38
b4f2fd3
to
8e21b67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Synced Patterns
Related to synced patterns (formerly reusable blocks)
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Re-attempts #65408, which was merged to trunk but then reverted because of a performance issue.
This time keeping a close eye on performance tests.
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast