Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick "ToggleGroupControl: Don't autoselect option on first group focus (#65892)" to wp/6.7 #66046

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

kevin940726
Copy link
Member

What and Why?

Manually cherry-pick ToggleGroupControl: Don't autoselect option on first group focus to wp/6.7.

How?

Follow the steps in #65892 (comment)

Testing Instructions

N/A

Testing Instructions for Keyboard

N/A

Screenshots or screencast

N/A

@kevin940726 kevin940726 added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components labels Oct 11, 2024
@kevin940726 kevin940726 requested review from getdave and mirka October 11, 2024 09:02
@kevin940726 kevin940726 self-assigned this Oct 11, 2024
@kevin940726 kevin940726 force-pushed the fix/cherry-pick-65892 branch from d99cd82 to c510555 Compare October 11, 2024 11:06
Copy link

github-actions bot commented Oct 11, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>
Co-authored-by: kevin940726 <kevin940726@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Comment on lines +16 to +17
- `Tooltip`: add `aria-describedby` to the anchor only if not redundant ([#65989](https://github.com/WordPress/gutenberg/pull/65989)).
- `PaletteEdit`: dedupe palette element slugs ([#65772](https://github.com/WordPress/gutenberg/pull/65772)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were these two fixes cherry-picked into the branch, too? The rest looks great.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are moved from the above. They seem to be backported too!

What should we do if these were not backported, though? Should we leave them in the "Unreleased" section or remove them?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove them completely if not cherry-picked before.

@kevin940726 kevin940726 force-pushed the fix/cherry-pick-65892 branch from c510555 to 4d8b7e9 Compare October 11, 2024 12:01
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

)

* ToggleGroupControl: Don't autoselect option on first group focus

* Fix test

* Add changelog

Co-authored-by: mirka <0mirka00@git.wordpress.org>
Co-authored-by: ciampo <mciampini@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: jeryj <jeryj@git.wordpress.org>
@kevin940726 kevin940726 force-pushed the fix/cherry-pick-65892 branch from 4d8b7e9 to aa19106 Compare October 14, 2024 01:53
@kevin940726 kevin940726 merged commit c9bda99 into wp/6.7 Oct 14, 2024
60 checks passed
@kevin940726 kevin940726 deleted the fix/cherry-pick-65892 branch October 14, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants