-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add foundations:elevation to storybook #66124
Conversation
@mirka is this something you can help with, since you've been taking a look at other Storybook-related tasks? |
|
||
## Tokens | ||
|
||
Use tokens to apply elevation in your work. Please refer to the Tokens section of Storybook to learn more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make sure to add a link to the Elevation tokens page once it lands in #66122.
Re. links, does this section of the docs help? |
I pushed an example for adding images: ea10ad0 |
Thanks y'all, I added a link to the tokens section, obviously it will be broken until #66122 is merged, so let's hold off on this one until then. |
Flaky tests detected in 9e8f2e8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11403553684
|
65fea22
to
879113e
Compare
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased to include the tokens page, and applied a few improvements / fixes.
Code-wise, this is LGTM 🚀
I'll leave it to @WordPress/gutenberg-design to merge it when they're happy with the contents of the page.
Added an internal link from the tokens page to the foundation page. I think this is good as an initial iteration :) |
Disabled auto-merge. I noticed a couple of copy tweaks to make, and I'm going to add a graphic to better demonstrate the examples :) |
Cool! I'll leave the merging to you :) |
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
Related to #66122.
What?
Adds a page detailing elevation as a foundation of the overall design language.
Why?
To help guide end users about how to use elevation when working with the WordPress components package, or when creating new UIs.
Testing Instructions
npm run storybook:dev
Missing pieces
This PR is a draft for now. I'd welcome assistance with adding: