-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabs: expose active tab item props, use ariakit prop types #66223
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 🚀
Just left a few minor suggestions and questions.
576c320
to
ed6be72
Compare
Thank you for the review, @tyxla ! All feedback address, will merge as soon as CI checks pass ✅ |
Flaky tests detected in ed6be72. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11403118754
|
…#66223) Co-authored-by: ciampo <mciampini@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
What?
Extracted from #66097 (comment)
This PR adds 3 more props on the
Tabs
component:activeTabId
,defaultActiveTabId
andonActiveTabIdChange
, and tweaks all prop types to use ariakit type defs under the hoodWhy?
The new props are necessary to control, in some cases, which tab is the active composite item (see #66097 (comment)).
Updating the prop types align
Tabs
with other recent ariakit-based components, such asComposite
andDropdownMenuV2
.How?
Testing Instructions
Review the code and the README. No runtime changes.