[6.7] Editor: Remove edit template menu item from block settings menu in blocks outside template. (#65560) #66339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocks outside template. (#65560)
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +10 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Oct 22, 2024
| @@ -48,10 +48,14 @@ function ContentOnlySettingsMenuItems( { clientId, onClose } ) { | |||
| } else { | |||
| const { getCurrentTemplateId } = select( editorStore ); | |||
| const templateId = getCurrentTemplateId(); | |||
| const { getContentLockingParent } = unlock( | |||
| const { getContentLockingParent, getRenderingMode } = unlock( | |||
There was a problem hiding this comment.
getRenderingMode is in the editor store.
|
Flaky tests detected in 2effcf0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11464559418
|
youknowriad
approved these changes
Oct 22, 2024
|
Was this a backport of #65560? I'll remove the backport label on the original PR then 👍. |
|
Yes, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Originally #65560.
I had to manually rebase. The problem is that there's a
getContentLockingParentcondition that is in the6.7, but not intrunk. And there's agetBlockParentscondition that is intrunk, but not in6.7.I decided to only pick out the extra mode condition.
Why?
It's needed for #66311.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast