[6.7] Zoom out: maintain scroll position (#61465) #66343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajlende
added
[Type] Bug
|
Size Change: +460 B (+0.03%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
jeryj
reviewed
Oct 24, 2024
| const prevContainerHeightRef = useRef( containerHeight ); | ||
|
|
||
| // Scroll based on the new scale | ||
| useEffect( () => { |
There was a problem hiding this comment.
Should/could this happen within the same useEffect as the useEffect that runs when toggling zoom out (that adds the animation classnames with handleZoomOutAnimationClassname)?
|
Closing in favor of #66618 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
It's faster for me to uncover potential issues with the release by developing here instead of
trunkright now.If there are no conflicts with
trunkwhen development is done, I'll move these changes back over there to merge intrunkand follow the automated backport workflow.What?
Manual backport of #61465
Why?
How?
Animating the scroll position in JS to match the
editor-canvas-resize-animationin CSS.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast