Zoom Out: Fix bouncy drop zones #66399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
talldan
added
the
Backport to WP 6.7 Beta/RC
|
Size Change: +1 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
|
Tested this and it feels much better! Some oddness I noticed (using Chrome and WP Playground to test) is that sometimes the dropzone under the header and above the footer randomly disappears: randomly.can.t.add.patterns.under.header.or.above.footer.movI'm not quite sure why it happens and can't quite replicate it clearly. Here's more of the same, along with a VERY tiny notice at the end to "drop files to upload":
drop.files.to.upload.mov |
getdave
approved these changes
Oct 24, 2024
There was a problem hiding this comment.
This is so much better! Thank you for tracking this down and fixing @talldan.
For me this is a vast improvement and we should ship it and backport to 6.7.
If there's another edge case with what Anne noticed then we can circle back to that. I certainly cannot replicate it in my testing.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Infinitely better 🎉 |
Co-authored-by: Dave Smith <getdavemail@gmail.com>
I tried a few times, but it's definitely a tricky one to replicate.
Oh yep, that one's easy to reproduce using that Patton pattern. I think this is an issue with the cover block's media drop zone. I'll try to debug it, and if I can make a separate PR. |
|
Seems like the cover block issue is non zoom out related. You can drag any blocks into a cover block, and it seems to think blocks are files 😱 Kapture.2024-10-24.at.16.34.54.mp4 |
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 24, 2024
* Also consider child elements of insertion point in `isInsertionPoint` function * Also disable the root block list when in zoom out mode * Consider situations where the sectionRoot is also the root * Update comment Co-authored-by: Dave Smith <getdavemail@gmail.com> * Fix lint --------- Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: ndiego <ndiego@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org> Co-authored-by: stokesman <presstoke@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 2254850 |
getdave
reviewed
Oct 24, 2024
| // drop zones - the actual 'root' block list and the section root. | ||
| return { | ||
| isDropZoneDisabled: | ||
| isZoomOut() && sectionRootClientId !== '', |
|
I've made an issue for the Cover Block problems - #66422 I'm not sure if this is something to include in the 6.7 cycle, it might be an old bug, but it is affecting Zoom Out. |
Worth a look. Thanks Dan! |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
* Also consider child elements of insertion point in `isInsertionPoint` function * Also disable the root block list when in zoom out mode * Consider situations where the sectionRoot is also the root * Update comment Co-authored-by: Dave Smith <getdavemail@gmail.com> * Fix lint --------- Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: getdave <get_dave@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: ndiego <ndiego@git.wordpress.org> Co-authored-by: richtabor <richtabor@git.wordpress.org> Co-authored-by: colorful-tones <colorful-tones@git.wordpress.org> Co-authored-by: stokesman <presstoke@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #65927 (or at least one of the main issues)
Why?
Block drag and drop uses the
useBlockDropZonehook. Rather than each block being a drop zone, each block list is a drop zone.For Zoom Out, only the 'section' blocks are interactive—the only block list that's supposed to be active as a drop zone is the one represented by the
sectionRootClientId. This is handled by theuseSelectin theuseInnerBlocksPropshook, it returnsisDropZoneDisabled: truefor any block lists that are not the section root, and that's used to prevent binding theuseBlockDropZonehook.The bug - that hook has an early
if ( ! clientId )return in theuseSelect, which always returns a falsey for theisDropZoneDisabledvalue, so in a lot of cases zoom out would accidentally have two blocks lists acting as drop zones - the actual 'root' block list and the section root.This extra drop zone causes some rogue
onDragLeaveevents triggeringhideInsertionPoint.How?
Adds some extra logic in the selector for the root block list when zoom out is active. It is valid for the sectionRoot to be the actual root, so this is checked.
Separately I've also added some extra safety to the
isInsertionPointcheck, as this only tests against the outer element and not nested elements of the insertion point.Testing Instructions
In trunk: The Insertion Points shows and hides itself as you drag between the block and the margin
In this PR: The Insertion Point stays present as you drag back and forth.
Screenshots or screencast
Before
Kapture.2024-10-21.at.18.54.34.mp4
After
Kapture.2024-10-24.at.11.17.38.mp4