getDefaultTemplateId: ensure entity config is loaded #66650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +7 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 72c5196. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11617462864
|
ellatrix
added
the
No Core Sync Required
ellatrix
changed the title
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
If I understand the issue correctly, the finish resolution for |
Mamaduka
reviewed
Nov 1, 2024
| } ); | ||
| const template = await response.json(); | ||
| await resolveSelect.getEntitiesConfig( 'postType' ); |
There was a problem hiding this comment.
Let's add an inline comment here. Otherwise, the resolution seems out of place and can be accidentally removed.
Mamaduka
previously requested changes
Nov 1, 2024
|
@Mamaduka I tested the query block on the All Archives template in trunk, and it's stuck in a loading state there too? 🤔 |
|
@ellatrix, odd. It works fine on the latest trunk, but I get an infinite loop on this branch. |
ellatrix
force-pushed
the
try/safari-race-condition
branch
from
92f3afa
to
62b329b
Compare
|
@Mamaduka Ah, ok, it works on the latest trunk indeed. Rebased. Must have been fixed in a different PR. |
|
Indeed it was fixed via #66655. |
Mamaduka
approved these changes
Nov 1, 2024
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See #66579 (comment).
See #66647.
The problem was the the entities configs were not loaded when the template was received as an entity.
Why?
The Site Editor would not load in Safari without the temporary fix. See #66579 (comment).
How?
Ensure we wait for the entities config to be loaded.
Testing Instructions
Open the Site Editor in Safari.
Testing Instructions for Keyboard
Screenshots or screencast