Block Inspector: Restore bottom margin for RadioControl #66688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -112 B (-0.01%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
aaronrobertshaw
changed the title
aaronrobertshaw
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Thanks for the clean up here @t-hamano ✨
This is testing as advertised and follows the prior discussion on the original PR.
✅ Spacing for RadioControl looks correct now
| Before | After |
|---|---|
 |
 |
✅ Latest Posts' control spacing is now inline with other radio controls as previous inline comment indicated it should be.
|
I'll merge this so that it'll get included in RC 3. |
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Nov 4, 2024
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: up1512001 <up1512001@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 9631601 |
github-actions
bot
added
the
Backported to WP Core
|
Thanks for the review! |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: up1512001 <up1512001@git.wordpress.org> Co-authored-by: aaronrobertshaw <aaronrobertshaw@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem found in this comment: #64582 (comment)
What?
This PR restores the bottom margin for the
RadioControlcomponent in the block inspector.Why?
In #64582, the
RadioControlcomponent is no longer composed of theBaseControlcomponent, and therefore no longer has the expected bottom margin in the Block Inspector.This results in no space between the RadioControl component and the next control unless the developer explicitly applies space via a gap or similar.
How?
Reapply the bottom margin to the
RadioControlcomponent in the block inspector. Also, remove the style for the Latest Post block, which is no longer needed.Testing Instructions
Run the following code in your browser console and confirm that there is a space between the two controls.
Details
Latest Post block
Notice that visual changes have occurred. But these visual changes should match the rules adopted in #64526:
24pxto16pxRadioControlin the panel