Appender: fix initial position #66711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +17 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
ellatrix
approved these changes
Nov 4, 2024
|
Thanks for fixing this up! 🙇 |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66708
Follow up #66630 (See this comment:)
What?
Fixes the position of the "fake" appender that is rendered when the document is empty.
Why?
As I understand it, the initial appender (
.block-editor-default-block-appender .block-editor-inserter) is rendered outside the canvas, and the default appender (.block-editor-block-list__empty-block-inserter.block-editor-block-list__empty-block-inserter) after clicking on the block is rendered inside the canvas.I think this is because #66630 removed the CSS related to the initial appender from
content.css.How?
Re-add only the initial appender's CSS to
content.css. At the same time, improve the comments about the appender.Testing Instructions
Screenshots or screencast