Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextControl: Deprecate 36px default size #66745

Merged
merged 6 commits into from
Nov 18, 2024

Conversation

vipul0425
Copy link
Contributor

Part of #65751

What?

Deprecate the 36px default size in TextControl.

Testing Instructions

  • Unit tests pass
  • Storybook stories should not log console warnings
  • All code snippets in documentation (JSDoc, Storybook, README) should have the __next40pxDefaultSize prop enabled

Copy link

github-actions bot commented Nov 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: vipul0425 <vipulgupta003@git.wordpress.org>
Co-authored-by: mirka <0mirka00@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@t-hamano t-hamano added the [Package] Components /packages/components label Nov 8, 2024
@mirka mirka requested a review from a team November 15, 2024 22:50
@mirka mirka added the [Type] Code Quality Issues or PRs that relate to code quality label Nov 15, 2024
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good 👍

In addition to this though, there are a lot of code snippets in Markdown files and Storybook stories across the repo that use TextControl, and all of them need the prop. Otherwise the devs referring to those snippets would be copy pasting deprecated code. (I added some clarification in the original issue's procedure checklist.)

packages/components/src/text-control/index.tsx Outdated Show resolved Hide resolved
@vipul0425
Copy link
Contributor Author

Hi @mirka I have updated the markdown files and stories.
Thanks 🙇

Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@mirka mirka enabled auto-merge (squash) November 18, 2024 20:57
@mirka mirka merged commit 1490795 into WordPress:trunk Nov 18, 2024
59 of 61 checks passed
@github-actions github-actions bot added this to the Gutenberg 19.8 milestone Nov 18, 2024
@mirka mirka added the Needs Dev Note Requires a developer note for a major WordPress release cycle label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Dev Note Requires a developer note for a major WordPress release cycle [Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants