-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UnitControl : Deprecate 36px default size #66791
UnitControl : Deprecate 36px default size #66791
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Hi @mirka, Some of this unit test are failing because, this Let me know if we have some other approach to handle this case? Thank You, |
…from parent component used
This is now fixed, checked the comment - #65751 (comment), and updated the PR to not log warning from the child component used. Thank You, |
…updated readme as well
… from child component
Hi @mirka, Updated the PR with requested changes and the suggestions 🙇. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the meticulous work! I'm just going to revert the changes on font-size-picker/index.native.js
, because *.native.js
files are for the mobile app and are mostly unrelated to the normal component code we're working on.
Got the point 👍 |
Part of #65751
What?
Deprecate the 36px default size in UnitControl.
Testing Instructions