Block Editor: Fix React Compiler error for 'BlockProps' util component #66809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.82 MB ℹ️ View Unchanged
|
tyxla
approved these changes
Nov 7, 2024
|
Flaky tests detected in 3830ac2. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11719518500
|
ellatrix
reviewed
Nov 7, 2024
| setAllWrapperProps, | ||
| ...props | ||
| } ) { | ||
| const wrapperProps = hook( props ); |
There was a problem hiding this comment.
Passing hooks as pros and the calling then isn’t allowed. The error in description has link with more info.
There was a problem hiding this comment.
What if we pass the feature? These are all constant. Or add feature IDs and then grab the feature in the component.
There was a problem hiding this comment.
Sorry, I don’t follow. Can you share a code example?
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…ss#66809) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #61788.
PR fixes the React Compile error for the 'BlockProps' util component by renaming it during destructure. This is similar to how the commands loader avoids a similar error.
gutenberg/packages/commands/src/components/command-menu.js
Line 38 in 8be8e46
Why?
Testing Instructions
All CI checks should be green; we're just renaming the prop.