Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook: fix DataViews layout #66999

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

oandregal
Copy link
Member

What?

The layout prop for the story didn't have the data defined in default layouts.

Why?

The styles defined in layout.styles wouldn't work.

Testing Instructions

npm install && npm run storybook:dev

Change the styles provided via defaultLayouts.table.layout.styles.description and verify that they are applied (max-width, etc. are inline styles of the table cell).

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: oandregal <oandregal@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@oandregal oandregal self-assigned this Nov 14, 2024
@oandregal oandregal added [Type] Bug An existing feature does not function as intended Storybook Storybook and its stories for components labels Nov 14, 2024
@oandregal oandregal merged commit 46ab740 into trunk Nov 14, 2024
46 checks passed
@oandregal oandregal deleted the fix/storybook-defaultlayout branch November 14, 2024 12:26
@github-actions github-actions bot added this to the Gutenberg 19.8 milestone Nov 14, 2024
Copy link

Flaky tests detected in fa3485f.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11837135466
📝 Reported issues:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storybook Storybook and its stories for components [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant