SlotFill: fix dependencies of registration effects, deduplicate code #67071
Conversation
jsnajdr
added
[Type] Code Quality
jsnajdr
requested review from
Mamaduka,
youknowriad,
mirka,
ciampo and
tyxla
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| @@ -11,7 +11,7 @@ import useSlot from './use-slot'; | |||
| import type { FillComponentProps } from './types'; | |||
|
|
|||
| export default function Fill( { name, children }: FillComponentProps ) { | |||
| const { registerFill, unregisterFill } = useContext( SlotFillContext ); | |||
| const registry = useContext( SlotFillContext ); | |||
There was a problem hiding this comment.
Is this a stable value?
There was a problem hiding this comment.
Yes, as long as the context provider is the same, the registry is a constant object.
jsnajdr
force-pushed
the
update/slot-fill-effects
branch
from
23864f6
to
52f0c8f
Compare
|
For some reason the e2es are failing repeatedly. It's a low level failure -- failed WP database connection. |
|
Flaky tests detected in 52f0c8f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11892091496
|
This PR tidies up the code for a
Fillregistration and rendering.For registration and unregistration, there used to be two effects: one runs on mount/unmount, another on
namechange. They can be easily merged into one with a[ name ]dependency. Registration and unregistration still happens at exactly the right times. And also theref.current.namevalue is updated whennamechanges.There's also a second effect that updates
ref.current.childrenand rerenders the slot whenchildrenchange. This one needs additionalslotdependency. Theslotobject is constant the entire time a slot is mounted.