Block Editor: Fix JS error in the 'useTabNav' hook #67102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Nov 19, 2024
| @@ -64,7 +64,7 @@ export default function useTabNav() { | |||
| .focus(); | |||
| } | |||
| // If we don't have any section blocks, focus the section root. | |||
| else { | |||
| else if ( sectionRootClientId ) { | |||
There was a problem hiding this comment.
Should we provide a fallback here? However, I'm not sure what the best one is for Zoom Out mode.
There was a problem hiding this comment.
@getdave - is the intention that getSectionRootClientId() will always return something? My question is, should we handle a fallback in case there isn't a section root, or is the bug that a sectionRoot should always be defined?
There was a problem hiding this comment.
Well, technically, it does; it returns an empty string, "," which in the editor means the main root. But it's only an internal marker, has no representation in Canvas, and can't be focused.
There was a problem hiding this comment.
It's important to be able to access the editor canvas and know it's empty. I'd support moving focus to the canvas wrapper as a fallback. If there are no empty states or focus, we can add those in a follow-up.
There was a problem hiding this comment.
In terms of fallback I'd just allow it to focus the canvas if the section root is an empty string.
|
Size Change: +5 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
fix/use-tab-nav-focus-error
branch
from
52ebe57
to
8920245
Compare
Mamaduka
force-pushed
the
fix/use-tab-nav-focus-error
branch
from
8920245
to
ef210ef
Compare
|
Flaky tests detected in ef210ef. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12024478497
|
|
Also realised that #67232 will help guard against this. But we still need this PR. |
getdave
approved these changes
Nov 28, 2024
|
Thanks for testing, @getdave! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR fixes the JS error in the
useTabNavhook whensectionRootClientIdisn't available in Zoom Out mode.Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast