Inline Commenting: Update collab sidebar style #67221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akasunil
added
[Type] Enhancement
|
Size Change: +80 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I think we'll want to use the theme's global style background here, so it looks like the canvas is behind the comments. Right now I'm not seeing a green colour behind the comments: 
|
|
My apologies for not being clearer. Is I gathered feedback from folks, the idea of coloring the background of the sidebar was dismissed, in favor of:
The mockups here, and in the main issue, are up to date, and include that. Sorry about the back and forth! Edit: To clarify: I'm describing here the behavior from a user POV. Technically I'll defer to you on whether it's sidebar(s) plural or not. We could end up with:
The latter is the one with a white background. Perhaps it simply toggles off the ones in the canvas when opened. |
|
Yes, in that case we still want to colour one of the sidebars to appear as an extension |
|
Updated #66417. I think in that case, let's keep the current sidebar as the second chronological sidebar, and create a new sidebar that feels as an extension of the canvas (as described on the issue). |
|
Closing this in favor of #67347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of - #66377
What? & Why?
Originally mentioned in #66377 (comment), Styling the collaboration sidebar in such a way that comment boards appear to be in the editor canvas.
Testing Instructions
Gutenberg->ExperimentsScreenshots or screencast