Editor: Update focus return handler for the Featured Image #67236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
Size Change: -19 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
force-pushed
the
try/feature-image-panel-focus
branch
from
a26541d
to
89b12da
Compare
|
Thanks for looking into this @Mamaduka As a learning opportunity for me, do I get it correctly that the ref callback will be always called (but won't do anything) even when:
I guess there are no big downsides with those extra calls? |
|
Yes, this ref callback (
No downsides here. React already does something similar internally to assign the P.S. When ref callback has a stable reference ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #66936.
PR tries an alternative method to return focus to the Featured Image toggle button. Instead of an arbitrary timeout, it uses a ref callback and a flag to focus the button when it's rendered.
Why?
While the timeout callback seems to work, it's not guaranteed what element will be rendered when the callback runs.
Testing Instructions
wp post meta update <post-id> _thumbnail_id 999999.Testing Instructions for Keyboard
Same.
Screenshots or screencast