Block Manager: Make it a private component in the block editor package #67255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +110 B (+0.01%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
ramonjd
reviewed
Nov 24, 2024
ramonjd
approved these changes
Nov 25, 2024
|
Thanks for the review!
I researched this and found the following. Are these behaviors correct?
In any case, it's not related to this PR, so I would like to merge it. |
|
@ellatrix would know best, maybe there are reasons that force us to load "content.css" in the root document but conceptually it's not really meant for the root document and more for the iframe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlockManagercomponent reusable #67052allowedBlocksin blocks that support it #62703 (See this comment)What?
Regarding the block manager component:
editorpackage to theblock-editorpackage.Why?
This PR is needed to use the
BlockManagercomponent in the UI for allowedBlocks.From this comment:
How?
editor-block-managerprefix has been replaced with theblock-editor-block-managerprefix in bulk.Since the
BlockManagercomponent was not originally a publicly available component, there should be no backward compatibility issues even if the package is moved.My only concern is whether there are any plugins that rely on the
.editor-block-manager__CSS classes to customize the "Manage block visibility" settings, but that doesn't seem to be the case with the WPdirectory results.Testing Instructions
The "Manage block visibility" setting should continue to work as before. Most of the functionality should be guaranteed by this E2E test.