LetteringSpacingControl: Deprecate 36px default size #67429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mirka
commented
Nov 29, 2024
| @@ -12,13 +12,14 @@ This component is used for blocks that display text, commonly inside a | |||
| Renders a letter spacing control. | |||
|
|
|||
| ```jsx | |||
| import { LetterSpacingControl } from '@wordpress/block-editor'; | |||
| import { __experimentalLetterSpacingControl as LetterSpacingControl } from '@wordpress/block-editor'; | |||
There was a problem hiding this comment.
Import statement in the code snippet was wrong.
Comment on lines
+40
to
+43
| if ( | ||
| ! __next40pxDefaultSize && | ||
| ( otherProps.size === undefined || otherProps.size === 'default' ) | ||
| ) { |
There was a problem hiding this comment.
There are only four places in this package where we need this logic, so I think we can just copy paste this without abstracting to a utility function.
24 tasks
|
Size Change: +84 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7f9351a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12087342482
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #65751
What?
Deprecates the 36px default size on
LetterSpacingControl.Testing Instructions
Add a Paragraph block in the block editor and add a Letter Spacing control from the Typography section in the block inspector.
Changing the props on here should log a warning (e.g. removing the
sizeprop):gutenberg/packages/block-editor/src/components/global-styles/typography-panel.js
Lines 493 to 498 in edd6328