DataViews: Move template and pattern title fields #67449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Feature] Extensibility
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ntsekouras
added
the
[Type] Task
|
Size Change: +323 B (+0.02%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
ntsekouras
commented
Dec 1, 2024
| { decodeEntities( renderedTitle ) || __( '(no title)' ) } | ||
| </span> | ||
| { suffix } | ||
| <span>{ renderedTitle || __( '(no title)' ) }</span> |
There was a problem hiding this comment.
getItemTitle decode entities already.
youknowriad
reviewed
Dec 2, 2024
oandregal
reviewed
Dec 2, 2024
oandregal
reviewed
Dec 2, 2024
oandregal
reviewed
Dec 2, 2024
ntsekouras
force-pushed
the
fields/move-template-title-field
branch
from
d2a758b to
3a0e3b6
Compare
ntsekouras
changed the title
ntsekouras
force-pushed
the
fields/move-template-title-field
branch
3 times, most recently
from
9454f24 to
4d9d9ad
Compare
|
I didn't spot any issues in the design 👍 |
ntsekouras
force-pushed
the
fields/move-template-title-field
branch
from
4d9d9ad to
fe08862
Compare
|
Flaky tests detected in fe08862. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12154580981
|
oandregal
reviewed
Dec 4, 2024
oandregal
reviewed
Dec 4, 2024
oandregal
reviewed
Dec 4, 2024
oandregal
reviewed
Dec 4, 2024
oandregal
reviewed
Dec 4, 2024
oandregal
reviewed
Dec 4, 2024
oandregal
reviewed
Dec 4, 2024
oandregal
reviewed
Dec 4, 2024
oandregal
reviewed
Dec 4, 2024
oandregal
reviewed
Dec 4, 2024
ntsekouras
force-pushed
the
fields/move-template-title-field
branch
from
fe08862 to
e69c504
Compare
oandregal
reviewed
Dec 4, 2024
oandregal
approved these changes
Dec 5, 2024
ntsekouras
force-pushed
the
fields/move-template-title-field
branch
from
8ebf4fb to
1fa1eec
Compare
youknowriad
reviewed
Dec 5, 2024
| color: var(--wp-admin-theme-color); | ||
| } | ||
| @include link-reset(); | ||
| } |
There was a problem hiding this comment.
Why did you add these styles (per curiosity)
There was a problem hiding this comment.
They were related to all our views. Before we had similar styles in patterns and templates, though they were also coming by using buttons and links in titles.
Now they are all the same internally (span) and handle the redirect with onClickItem, so these styles are used by all views.
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #61084
This PR moves the
templateTitle and patternTitlefields tofieldspackage. Additionally a separatepageTitleFieldwas created due to the special frontpage/posts page handling and all of them use the underlyingBaseTitleField.For the above I update some classNames and moved around some styles.
Testing Instructions
titlefields and theironClickbehavior/navigation.