Block Editor: Animate useScaleCanvas() only when toggling zoomed out mode
#67481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Bug
tyxla
requested review from
draganescu,
Mamaduka,
youknowriad,
jsnajdr,
jeryj and
ajlende
tyxla
changed the title
useScaleCanvas() only when toggling zoomed out mode
|
Size Change: +9 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
ellatrix
approved these changes
Dec 2, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
im3dabasia
pushed a commit
to im3dabasia/gutenberg
that referenced
this pull request
Dec 4, 2024
…mode (WordPress#67481) Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes an error that occurs when navigating directly to block styles of a particular block in the site editor.
Alternative of #67375.
Why?
Just fixing an error that seems to have been introduced in #66917.
Found while testing #67199.
How?
We're only starting calculations for the zoomed out animation if the user actually toggled the zoomed out mode.
Previously, the calculations were running when attempting to "directly" load the page with styles of a particular block.
Testing Instructions
/wp-admin/site-editor.php?p=%2Fstyles§ion=%2Fblocks%2Fcore%252Fheadingdirectly (not by navigating to it)Testing Instructions for Keyboard
Same
Screenshots or screencast