Storybook: Remove unnecessary feature flags #67576
Merged
+0
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
commented
Dec 4, 2024
| @@ -60,11 +60,6 @@ module.exports = { | |||
| name: '@storybook/react-webpack5', | |||
| options: {}, | |||
| }, | |||
| features: { | |||
| babelModeV7: true, | |||
There was a problem hiding this comment.
Babel mode is the default since v7, see https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#babel-mode-v7-exclusively
| @@ -60,11 +60,6 @@ module.exports = { | |||
| name: '@storybook/react-webpack5', | |||
| options: {}, | |||
| }, | |||
| features: { | |||
| babelModeV7: true, | |||
| emotionAlias: false, | |||
There was a problem hiding this comment.
We're using Emotion 11 so this is not necessary, and the flag was removed anyway, see https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#70-feature-flags-removed
| features: { | ||
| babelModeV7: true, | ||
| emotionAlias: false, | ||
| storyStoreV7: true, |
There was a problem hiding this comment.
Unnecessary, since it's enabled by default since Storybook v7, see https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#storystorev7-enabled-by-default
|
Size Change: 0 B Total Size: 1.83 MB ℹ️ View Unchanged
|
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In preparation for upgrading Storybook to v8, this PR cleans up unnecessary feature flags.
See inline comments for more details.
Part of #67574.
Why?
These feature flags are no longer necessary.
Some of those flags throw errors in v8.
How?
Removing the unnecessary feature flags.
Testing Instructions
Verify Storybook builds correctly with no errors and there are no visual or behavioral differences.
Testing Instructions for Keyboard
Same
Screenshots or screencast
None