Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled: Suppress contentEditable warning in story #67679

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Dec 6, 2024

What?

Fixes a warning in the Disabled story.

Why?

The behavior in the story is intentional, so the warning is not necessary.

Found while working on #67574.

How?

We're adding the suppressContentEditableWarning prop to intentionally suppress the warning React generates.

Testing Instructions

Testing Instructions for Keyboard

Same

Screenshots or screencast

Warning before this PR:

Screenshot 2024-12-06 at 11 28 57

@tyxla tyxla added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components Storybook Storybook and its stories for components labels Dec 6, 2024
@tyxla tyxla requested review from Mamaduka, t-hamano and a team December 6, 2024 09:29
@tyxla tyxla self-assigned this Dec 6, 2024
@tyxla tyxla requested a review from ajitbohra as a code owner December 6, 2024 09:29
Copy link

github-actions bot commented Dec 6, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: tyxla <tyxla@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about suppressContentEditableWarning.

@tyxla tyxla enabled auto-merge (squash) December 6, 2024 10:27
@tyxla tyxla merged commit 71c6fb6 into trunk Dec 6, 2024
71 of 73 checks passed
@tyxla tyxla deleted the update/disabled-content-editable-warnings branch December 6, 2024 10:42
@github-actions github-actions bot added this to the Gutenberg 19.9 milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components Storybook Storybook and its stories for components [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants