ChildLayoutControl: Use units defined in theme.json #67784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +13 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
tellthemachines
approved these changes
Dec 11, 2024
|
@tellthemachines Thanks for the review! |
|
Flaky tests detected in 653235c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12271566107
|
|
@t-hamano you're the best! such a common sense fix that must have slipped thru the cracks. i feel honored the creator of the piano block jumped on my issue! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #67750
Why?
Currently, this component does not pass a
unitprop to its internalUnitControl, so the default units will always be used. Like most other controls, I think it should respect the unit values defined in theme.json.Testing Instructions
{ "version": 3, "settings": { "appearanceTools": true, "layout": { "contentSize": "840px", "wideSize": "1100px" }, "spacing": { "units": [ "px", "em", "rem", "vh", "vw", "%", "dvh", "dvw" ] } } }Screenshots or screencast