Improve the block switcher a11y #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
approved these changes
May 8, 2017
There was a problem hiding this comment.
Code looks good 👍 I'll defer to @jasmussen for feedback on wording; might depend on how much we want to commit to block terminology in these labels, i.e. "Block types" instead of "Content types".
|
Is the word "content" necessary? I'd prefer simply "Change block type" and "Types", but that's not a strong opinion. |
|
@afercia you have a thumbs up on this one. Would you like me to rebase this and merge it in? |
|
@jasmussen sure, I think the focus management issue is broader than this PR and will probably need a broader approach so 👍 for this PR. |
|
👍 👍 rebasing and merging. |
jasmussen
force-pushed
the
update/better-block-switcher-a11y
branch
from
55dc25c
to
176e195
Compare
|
Thank you for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As done for the Inserter (see #527 ) this PR adds ARIA roles, states, and properties to the Block switcher.
Adds focus style to the menu items, same as hover.
Also, adds an
aria-labelto the block switcher toggle button and to the menu. Any suggestions for a better wording very welcome, for now the labels are:Change block content typeon the toggleContent typeson the menuThe block switcher menu will need also arrow keys navigation, see #696
Collapsed:
Expanded:
Menu label:
Fixes #695