Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in Spacer block #7024

Merged
merged 2 commits into from
May 30, 2018
Merged

Fix regression in Spacer block #7024

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1679047
Fix regression in Spacer block
jasmussen May 30, 2018
69f3bdd
Change classnames in the CSS not the JS
jasmussen May 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core-blocks/spacer/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ export const settings = {
} }
minHeight="20"
handleClasses={ {
top: 'core-blocks-spacer__resize-handler-top',
bottom: 'core-blocks-spacer__resize-handler-bottom',
top: 'block-spacer__resize-handler-top',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should update the stylesheet instead ;) These class names do not follow our guidelines ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I'm about to hop on a meeting, if you have bandwidth feel free to commandeer this PR :D

bottom: 'block-spacer__resize-handler-bottom',
} }
enable={ {
top: true,
Expand Down