Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Palette support setup with single array argument (backwards compatible) #7025

Closed
wants to merge 2 commits into from
Closed

Color Palette support setup with single array argument (backwards compatible) #7025

wants to merge 2 commits into from

Conversation

webmandesign
Copy link
Contributor

Description

Allowing editor-color-palette theme support setup with a single array of colors parameter/argument. This way only one argument is passed to add_theme_support( 'editor-color-palette', $arg ) instead of multiple arguments for each color.

This code is backwards compatible with current implementation (colors are passed as multiple parameters/arguments).

Fising issue #6425

Contains backwards compatibility code for setting Color Palette support as multiple parameters.
@webmandesign
Copy link
Contributor Author

This code has been discussed in #6437 that was closed due to messy rebase.

@chrisvanpatten
Copy link
Contributor

Would it be possible to refresh this and look at landing it it with 3.2? Happy to do it myself if you aren't available @webmandesign.

(cc @jorgefilipecosta, since you reviewed the original PR!)

@webmandesign
Copy link
Contributor Author

@chrisvanpatten Thanks, I'm OK doing it myself.
I've already done a rebase of my original/previous PR for the issue and it seemed to be very messy (at least from my point of view). As this PR is behind master again (more than 180 commits behind), I will create a new one, so the code will be cleaner. I'm on it ;)

@webmandesign webmandesign deleted the update/theme-support-color-palette-array branch June 28, 2018 19:39
@webmandesign
Copy link
Contributor Author

@chrisvanpatten @jorgefilipecosta
I've created a new PR with updated code matching current master. #7619

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants