-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Framework: Drop deprecations slated for 3.0 removal #7031
Conversation
@@ -249,7 +249,6 @@ function gutenberg_register_scripts_and_styles() { | |||
'wp-blocks', | |||
'wp-components', | |||
'wp-core-data', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that core-blocks
no longer depends on deprecated
.
@@ -25,7 +25,7 @@ import createSelector from 'rememo'; | |||
import { serialize, getBlockType, getBlockTypes, hasBlockSupport } from '@wordpress/blocks'; | |||
import { __ } from '@wordpress/i18n'; | |||
import { moment } from '@wordpress/date'; | |||
import { deprecated } from '@wordpress/utils'; | |||
import deprecated from '@wordpress/deprecated'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I included this fix to avoid double warning :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
This pull request seeks to remove deprecations slated for removal in the upcoming 3.0.0 release.
Specifically, this includes:
wp.blocks.registerCoreBlocks
removedSee: https://wordpress.org/gutenberg/handbook/reference/deprecated/#3-0-0
Testing instructions:
Verify that there are no regressions in impacted behavior, and importantly that no references to deprecated behaviors exist in core code.