Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7082 multiple hover styles #7104

Merged
merged 2 commits into from
Jun 19, 2018
Merged

Fix #7082 multiple hover styles #7104

merged 2 commits into from
Jun 19, 2018

Conversation

ixkaito
Copy link
Contributor

@ixkaito ixkaito commented Jun 3, 2018

Description

Fix the issue (#7028) that block toolbar buttons use multiple hover styles.

How has this been tested?

Ran npm test:

Test Suites: 1 skipped, 178 passed, 178 of 179 total
Tests:       3 skipped, 1598 passed, 1601 total
Snapshots:   59 passed, 59 total
Time:        54.724s
Ran all test suites.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@aduth aduth requested a review from jasmussen June 6, 2018 12:21
@aduth
Copy link
Member

aduth commented Jun 6, 2018

I believe the issue meant to be addressed is #7082 (the original comment mentions #7028).

@aduth aduth added Needs Design Feedback Needs general design feedback. [Feature] UI Components Impacts or related to the UI component system labels Jun 6, 2018
@ixkaito
Copy link
Contributor Author

ixkaito commented Jun 6, 2018

@aduth Thanks! You're right. It's #7082 .

@jasmussen
Copy link
Contributor

Awesome, thanks so much for finding this issue and taking a stab at fixing it. Really appreciate it 🏅

There was an issue with your approach, though, which meant that hover styles were broken for other icon buttons as a result of this. For example this button needs the hover style supplied by the box shadow:

screen shot 2018-06-07 at 08 59 30

I took the liberty of pushing a tweak to your code, which instead hides the hover style on the formatting button itself instead of in the icon button component:

screen shot 2018-06-07 at 08 59 34

Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well now!

I'll let @aduth take a quick look and merge if it's 👍 👍

@ixkaito
Copy link
Contributor Author

ixkaito commented Jun 7, 2018

@jasmussen Thank you for your follow-up!

@jasmussen jasmussen requested a review from a team June 12, 2018 09:28
@jasmussen
Copy link
Contributor

Merging as this would be good to get in master.

@jasmussen jasmussen merged commit 14531c4 into WordPress:master Jun 19, 2018
@jasmussen jasmussen added this to the 3.1 milestone Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system Needs Design Feedback Needs general design feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants