Testing: Add e2e test for PluginPostStatusInfo #7284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Automated Testing
gziolo
changed the title
gziolo
force-pushed
the
update/plugins-api-e2e
branch
from
df4b062
to
62a3123
Compare
gziolo
force-pushed
the
update/plugins-api-e2e
branch
from
62a3123
to
d6b7f0c
Compare
test/e2e/support/utils.js
Outdated
| /** | ||
| * Clicks on the button in the header which opens Document Settings sidebar when it is closed. | ||
| */ | ||
| export async function ensureDocumentSettingsSidebarIsOpened() { |
There was a problem hiding this comment.
Not certain if this is the best name for the function, because if Publish panel is open, the button is not rendered and the function will not be able to ensure "document settings sidebar is opened".
An option is call the function click toggle sidebar or something similar but off course that name will bot transmit the main objective of clicking in the sidebar.
There was a problem hiding this comment.
Would openDocumentSettingsSidebar work for you?
There was a problem hiding this comment.
Yes openDocumentSettingsSidebar looks good, as it is not strong as "ensure".
test/e2e/specs/plugins-api.test.js
Outdated
|
|
||
| const pluginSidebarContent = await page.$eval( '.edit-post-sidebar', ( el ) => el.innerHTML ); | ||
| expect( pluginSidebarContent ).toMatchSnapshot(); | ||
| const pluginPostStatusInfoText = await page.$eval( '.my-post-status-info-plugin', ( el ) => el.innerText ); |
There was a problem hiding this comment.
I think we should improve the selector to `.edit-post-post-status .my-post-status-info-plugin' to test that it was rendered "inside" right now if we render outside of Document Setting sidebar the test will pass.
jorgefilipecosta
approved these changes
Jun 25, 2018
gziolo
force-pushed
the
update/plugins-api-e2e
branch
from
d6b7f0c
to
55fd7d0
Compare
gziolo
force-pushed
the
update/plugins-api-e2e
branch
from
55fd7d0
to
238c1c7
Compare
oxyc
added a commit
to generoi/gutenberg
that referenced
this pull request
Jun 26, 2018
* 'master' of https://github.com/WordPress/gutenberg: (69 commits) fix: Show permalink editor in editor (WordPress#7494) Fix text wrapping in Firefox. (WordPress#7472) Try another approach to fixing the sibling inserter in Firefox (WordPress#7530) fix: Improve "add block" text in NUX onboarding (WordPress#7511) Implement core style of including revisions data on Post response (WordPress#7495) Testing: Add e2e test for PluginPostStatusInfo (WordPress#7284) Add end 2 end test for sidebar behaviours on mobile and desktop. (WordPress#6877) Only save metaboxes when it's not an autosave (WordPress#7502) Fix broken links in documentation (WordPress#7532) Remove post type 'viewable' compatibility shim (WordPress#7496) Fix typo. (WordPress#7528) Blocks: Remove wrapping div from paragraph block (WordPress#7477) fix: change import for InnerBlocks (WordPress#7484) Polish library just a teeeeensy bit (WordPress#7522) feat: Add snapshot update script (WordPress#7514) Display server error message when one exists (WordPress#7434) Fix issues with gallery in IE11. (WordPress#7465) Polish region focus style (WordPress#7459) Fix IE11 formatting toolbar visibility (WordPress#7413) Update plugin version to 3.1. (WordPress#7402) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Builds upon #7269.
This PR improves basic end-to-end tests for the
PluginSidebarandPluginSidebarMoreMenuItemregistration. In addition, it adds another test forPluginPostStatusInfo.It would be great to replace this snapshot for
PluginSidebarwith something which tests also data sync between the page title and its copy in the sidebar, but I keep it for later to make sure we have also the publish flow covered.Update: I also included the script with code that registers publish panels:
PluginPrePublishPanelandPluginPostPublishPanel. We still need to add some basics tests to make sure it works as expected. I can be in another PR.How has this been tested?
npm run test-e2eand Travis verification should be green.Checklist: