Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text wrapping in Firefox. #7472

Merged
merged 3 commits into from
Jun 26, 2018
Merged

Fix text wrapping in Firefox. #7472

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d194326
Fix text wrapping in Firefox.
Jun 22, 2018
922466a
Scope to block list.
Jun 25, 2018
3ca0073
docs: Tweak comment
tofumatt Jun 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions editor/components/block-list/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,9 @@
padding-left: $block-padding;
padding-right: $block-padding;

// Break long spaceless words so they don't overflow the block.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna add a comma after long here, because it should have one 😄

overflow-wrap: break-word;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is totally correct for Firefox; we had to add this to plenty of places in the Add-ons website.

I forget if Firefox is doing the "correct", but annoying, thing here (it feels like it), but yeah… this comes up a lot 😄


@include break-small() {
// The block mover needs to stay inside the block to allow clicks when hovering the block
padding-left: $block-padding + $block-side-ui-padding - $border-width;
Expand Down