Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improve "add block" text in NUX onboarding #7511

Merged
merged 3 commits into from
Jun 25, 2018
Merged

fix: Improve "add block" text in NUX onboarding #7511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66c1a18
fix: Improve "add block" text in NUX onboarding
tofumatt Jun 23, 2018
499cd22
Tidy up text a bit, make it make sense with the off-screen text too
tofumatt Jun 25, 2018
8f06539
Use editorial-approved copy!
tofumatt Jun 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion editor/components/default-block-appender/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export function DefaultBlockAppender( {
<InserterWithShortcuts rootUID={ rootUID } layout={ layout } />
<Inserter position="top right">
<DotTip id="core/editor.inserter">
{ __( 'Welcome to the wonderful world of blocks! Click ‘Add block’ to insert different kinds of content—text, images, quotes, video, lists, and much more.' ) }
{ __( 'Welcome to the wonderful world of blocks! Click the “+” (“Add block”) button to add a new block. There are blocks available for all kind of content: you can insert text, headings, images, lists, and lots more!' ) }
</DotTip>
</Inserter>
</div>
Expand Down
6 changes: 3 additions & 3 deletions editor/components/default-block-appender/test/__snapshots__/index.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ exports[`DefaultBlockAppender should append a default block when input focused 1
<WithSelect(WithDispatch(DotTip))
id="core/editor.inserter"
>
Welcome to the wonderful world of blocks! Click ‘Add block’ to insert different kinds of content—text, images, quotes, video, lists, and much more.
Welcome to the wonderful world of blocks! Click the “+” (“Add block”) button to add a new block. There are blocks available for all kind of content: you can insert text, headings, images, lists, and lots more!
</WithSelect(WithDispatch(DotTip))>
</WithSelect(WithDispatch(Inserter))>
</div>
Expand Down Expand Up @@ -72,7 +72,7 @@ exports[`DefaultBlockAppender should match snapshot 1`] = `
<WithSelect(WithDispatch(DotTip))
id="core/editor.inserter"
>
Welcome to the wonderful world of blocks! Click ‘Add block’ to insert different kinds of content—text, images, quotes, video, lists, and much more.
Welcome to the wonderful world of blocks! Click the “+” (“Add block”) button to add a new block. There are blocks available for all kind of content: you can insert text, headings, images, lists, and lots more!
</WithSelect(WithDispatch(DotTip))>
</WithSelect(WithDispatch(Inserter))>
</div>
Expand Down Expand Up @@ -102,7 +102,7 @@ exports[`DefaultBlockAppender should optionally show without prompt 1`] = `
<WithSelect(WithDispatch(DotTip))
id="core/editor.inserter"
>
Welcome to the wonderful world of blocks! Click ‘Add block’ to insert different kinds of content—text, images, quotes, video, lists, and much more.
Welcome to the wonderful world of blocks! Click the “+” (“Add block”) button to add a new block. There are blocks available for all kind of content: you can insert text, headings, images, lists, and lots more!
</WithSelect(WithDispatch(DotTip))>
</WithSelect(WithDispatch(Inserter))>
</div>
Expand Down