Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try splitting inline Editable #767

Closed
wants to merge 1 commit into from
Closed

Try splitting inline Editable #767

wants to merge 1 commit into from

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented May 11, 2017

See #536 and #579.

@ellatrix ellatrix changed the title Try splitting headings Try splitting inline Editable May 11, 2017
@ellatrix ellatrix added the [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable label May 11, 2017
@ellatrix
Copy link
Member Author

ellatrix commented May 11, 2017

There is an issue when splitting in formatting... :/ Still thinking we first have to normalise content and selection... These issues are much easier to solve then.

@ellatrix ellatrix force-pushed the try/split-heading branch from 852c84b to df11370 Compare May 16, 2017 17:50
@ellatrix
Copy link
Member Author

I'll assume we want to spilt heading immediately on enter and not behave like other inline Editables. We can then disable that behaviour by omitting onSplit. Looking into changing it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant