Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spacing in prepublish panel titles #7844

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Update spacing in prepublish panel titles #7844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions editor/components/post-publish-panel/prepublish.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,13 @@ function PostPublishPanelPrepublish( {
{ hasPublishAction && (
<Fragment>
<PanelBody initialOpen={ false } title={ [
__( 'Visibility: ' ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the whitespace should stay in these translation strings because it'll make screen readers, copy pasters, and semantic nitpickers like me happier that it's there. Technically the space is part of the translation here.

(See: #7842 (comment))

__( 'Visibility:' ),
<span className="editor-post-publish-panel__link" key="label"><PostVisibilityLabel /></span>,
] }>
<PostVisibility />
</PanelBody>
<PanelBody initialOpen={ false } title={ [
__( 'Publish: ' ),
__( 'Publish:' ),
<span className="editor-post-publish-panel__link" key="label"><PostScheduleLabel /></span>,
] }>
<PostSchedule />
Expand Down
1 change: 1 addition & 0 deletions editor/components/post-publish-panel/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@

.editor-post-publish-panel__link {
color: $blue-medium-700;
padding-left: 4px;
text-decoration: underline;
}

Expand Down