Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: Tag Cloud #7875

Merged
merged 19 commits into from
Feb 15, 2019
Merged

Blocks: Tag Cloud #7875

merged 19 commits into from
Feb 15, 2019

Conversation

jahvi
Copy link
Contributor

@jahvi jahvi commented Jul 10, 2018 •
edited
Loading

Description

This is my attempt at implementing the tag cloud widget as a Gutenberg block, it's still a work in progress but I wanted to get some initial feedback while I'm at it.

Continued from #4994.
Fixes #1801.

How has this been tested?

Tested in the latest master branch.

Screenshots

motion

Types of changes

New feature: tag cloud block

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@jahvi jahvi mentioned this pull request Jul 10, 2018
Closed
3 tasks
@Soean Soean added [Feature] Blocks Overall functionality of blocks New Block Suggestion for a new block Needs Design Feedback Needs general design feedback. labels Jul 16, 2018
@jahvi
Copy link
Contributor Author

jahvi commented Aug 16, 2018 •
edited
Loading

Updated PR to match changes from #8287

@jahvi
Copy link
Contributor Author

jahvi commented Oct 1, 2018

Any update on this one? I rebased the latest changes from master but not sure if I should refactor anything else.

@Soean
Copy link
Member

Soean commented Oct 9, 2018

@jahvi Can you rebase it again? I will test the block on my Gutenberg installation.

@jahvi
Copy link
Contributor Author

jahvi commented Oct 9, 2018

@Soean Sure thing, I just rebased it now.

@Soean Soean added the Needs Accessibility Feedback Need input from accessibility label Oct 10, 2018
@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Oct 11, 2018
@karmatosed
Copy link
Member

As we focus on phase 1 this will be moving to potential phase 2 and we can then consider it from there, For now, closing and moving to potential blocks for the future.

@karmatosed karmatosed closed this Oct 11, 2018
@karmatosed karmatosed reopened this Dec 14, 2018
@jahvi
Copy link
Contributor Author

jahvi commented Dec 15, 2018

Thanks for reopening, I just rebased and fixed some code to match the latest Gutenberg changes. I'm not sure how to fix the CI issues, can you guys advise?

@Soean
Copy link
Member

Soean commented Dec 15, 2018 •
edited
Loading

Nice work! You have to delete the generated test files and regenerate them.

Delete:

  • core__tag-cloud__showTagCounts.json
  • core__tag-cloud__showTagCounts.parsed.json
  • core__tag-cloud__showTagCounts.serialized.html
  • core__tag-cloud.json
  • core__tag-cloud.parsed.json
  • core__tag-cloud.serialized.html

Run: GENERATE_MISSING_FIXTURES=y npm run test-unit test/integration/full-content/full-content.spec.js

@youknowriad
Copy link
Contributor

I tested this and I feel it's good enough to land to include in Gutenberg 5.1. Follow-up improvements to styling, and messages can happen separately.

@youknowriad youknowriad merged commit b58fed3 into WordPress:master Feb 15, 2019
@youknowriad
Copy link
Contributor

Thanks everyone for the collaboration and @jahvi Awesome work

@jahvi
Copy link
Contributor Author

jahvi commented Feb 15, 2019

Thanks all for your help, I'll be glad to keep helping improve it.

@jahvi jahvi deleted the add/block-tag-cloud branch February 15, 2019 16:34
This was referenced Feb 18, 2019
Merged
Merged
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@jahvi @youknowriad
Blocks: Add a new Tag Cloud block (#7875)
8707dfc
youknowriad pushed a commit that referenced this pull request Mar 6, 2019
@jahvi @youknowriad
Blocks: Add a new Tag Cloud block (#7875)
b8609e4
This was referenced Apr 30, 2020
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Merged
Closed
Merged
Closed
Merged
Closed
Closed
Closed
This was referenced Jul 16, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduth aduth aduth left review comments

@afercia afercia afercia left review comments

@noisysocks noisysocks noisysocks left review comments

@gziolo gziolo gziolo approved these changes

@mapk mapk mapk approved these changes

@Soean Soean Soean left review comments

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@melchoyce melchoyce Awaiting requested review from melchoyce

@jorgefilipecosta jorgefilipecosta Awaiting requested review from jorgefilipecosta

@youknowriad youknowriad Awaiting requested review from youknowriad

@notnownikki notnownikki Awaiting requested review from notnownikki

@talldan talldan Awaiting requested review from talldan

Assignees

@jahvi jahvi

Labels
[Feature] Blocks Overall functionality of blocks [Feature] Widgets Screen The block-based screen that replaced widgets.php. Needs Accessibility Feedback Need input from accessibility Needs Design Feedback Needs general design feedback.
Projects
None yet
Milestone
5.1 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
10 participants
@jahvi @Soean @karmatosed @noisysocks @gziolo @melchoyce @afercia @mapk @youknowriad @aduth