NUX: Move first tip to the toolbar #9223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 09dc71c.
Move the first tip to the toolbar so that post content isn't covered, and adjust DotTip so that it can correctly position itself below the inserter button.
noisysocks
added
[Type] Enhancement
noisysocks
requested review from
talldan and
tofumatt
and removed request for
talldan
talldan
approved these changes
Aug 23, 2018
tofumatt
approved these changes
Aug 23, 2018
packages/nux/src/store/selectors.js
Outdated
| * @param {string} tipId The tip to query. | ||
| * @param {?number} instanceId A number which uniquely identifies the DotTip instance. | ||
| * @param {Object} state Global application state. | ||
| * @param {string} id The tip to query. |
There was a problem hiding this comment.
Any reason not to call this tipId over id?
There was a problem hiding this comment.
I don't see why not! 53eef0f
This was referenced Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8050. Reverts #8642.
Moves the first tip to the toolbar so that post content isn't covered, and adjusts
DotTipso that it can correctly position itself below buttons when necessary.Since doing this means that multiple instances of the same tip can no longer appear, I've reverted #8642 as it is no longer necessary.
How has this been tested?
Screenshots