Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the write story placeholder #9314

Closed
wants to merge 1 commit into from

Conversation

youknowriad
Copy link
Contributor

closes #9076

This PR tries to replace the "Write your story" placeholder with the paragraph placeholder "Add text or type / to add content" and also removes the default placeholder from the paragraph block.

Let me know how it feels.

@youknowriad youknowriad self-assigned this Aug 24, 2018
@youknowriad youknowriad added General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. labels Aug 24, 2018
@ZebulanStanphill
Copy link
Member

"Add text or type / to add content" has already felt a bit confusing to me. It looks like the slash is being used in an "or" kind of sense, as if the sentence says "Add text or type OR to add content", which is rather confusing. I feel like adding quotation marks around the slash would help:

Add text or type “/” to add content

What do you think? Ideally, you would wrap the slash with a <kbd> element, but I don't think you can use HTML elements in the placeholder text.

@jasmussen
Copy link
Contributor

Question: could we cycle through various tips? I like the idea of a few writing prompts intermingled with a few tips. Like "What's on your mind?" "Write your story..." could be two writing prompts, while "Add text or type /" etc. are essentially tips. So we could have an array of maybe 5 total, shown at random.

@youknowriad
Copy link
Contributor Author

@jasmussen yes we can unless there's an explicitly defined prompt by the WP filter.

I'm happy to update the PR once we reach consensus between the designers :P

@ZebulanStanphill I think it makes sense.

@0aveRyan
Copy link
Contributor

0aveRyan commented Aug 24, 2018

This appears a duplicate of #9076 Doh, missed mention above.

@karmatosed
Copy link
Member

Just to summarise, right now we have 2 options being suggested?

  • Add text or type / to add content in all cases.
  • Rotate around a few?

If I am right my concern with rotating is consistency. I am not set on the first option as the only way to write this though. What other options are there?

@earnjam
Copy link
Contributor

earnjam commented Aug 27, 2018

What about always using "Add text or type / to add content" on pages and any custom post types, but allowing the more engaging writing prompts to rotate on posts, which are generally going to be more writing-focused?

@kjellr
Copy link
Contributor

kjellr commented Sep 3, 2018

What about always using "Add text or type / to add content" on pages and any custom post types, but allowing the more engaging writing prompts to rotate on posts, which are generally going to be more writing-focused?

This seems like a solid direction to me. 👏

Since this is primarily copy-related at this point (and since it's already received feedback from a few designers), I'm going to remove the Needs Design Review label and add Needs Copy Review to get some copy feedback. 👍

@kjellr kjellr added Needs Copy Review Needs review of user-facing copy (language, phrasing) and removed Needs Design Feedback Needs general design feedback. labels Sep 3, 2018
@michelleweber
Copy link

Even with the quotations marks, "Add text or type /" feels a bit confusing -- isn't typing "/" adding text? If I can just start adding text, why do i need to bother with the /? Or does adding text specifically mean pasting?

@0aveRyan
Copy link
Contributor

0aveRyan commented Sep 7, 2018

@michelleweber I agree it feels a little awkward and doesn't explain itself. What are your thoughts on Add text... Type / to insert a block?

I realize there are already some contrast issues, but it'd be great to have a small, distinguishing design treatment for the / so it doesn't feel like a substitute for or (I realize the quotes were endeavoring for this, but not sure quoting a symbol using wrapping symbols is very clear).

screen shot 2018-09-06 at 5 29 09 pm

@jasmussen
Copy link
Contributor

Placeholder contrast will be addressed when #9562 is merged.

I think the point about making sure slash is not mistaken as "or" is a great point, but are there any verbiage changes we can make instead to ameliorate this?

Also worth noting that the slash command is noted in the Keyboard Shortcuts sheet now:

screen shot 2018-09-07 at 11 03 45

I'm personally of the opinion that while the slash command is great, it's okay that it's treated as a power user feature. I think if people start to think it's a primary way of inserting blocks, it will be a turnoff.

@michelleweber
Copy link

Typing the slash doesn't insert a text block, it pulls up a list of blocks you can add, right? If that's right, "Add text... Type / to insert a block" kinda makes it sound like all you can do is add text/a text block. It seems like we want something more like "To add a text block, just start writing. For quick access to other common blocks, type a /."

@kjellr
Copy link
Contributor

kjellr commented Sep 7, 2018

"To add a text block, just start writing. For quick access to other common blocks, type a /."

What about something like: Start writing or type / to choose a block?

I'm personally of the opinion that while the slash command is great, it's okay that it's treated as a power user feature. I think if people start to think it's a primary way of inserting blocks, it will be a turnoff.

I agree. I wonder if we can actually eliminate mention of the slash command from this placeholder and put it in a tip or something? If this is a power user feature, it doesn't make sense to show it on every single new line.

@jasmussen
Copy link
Contributor

Start writing or type / to choose a block?

I like that a lot.

I wonder if we can actually eliminate mention of the slash command from this placeholder and put it in a tip or something? If this is a power user feature, it doesn't make sense to show it on every single new line.

Possibly. For now, though, this is the primary way, based on the feedback we've received in chat and on Twitter, that people have discovered how to use the command. I suppose it's fine that they don't discover it at all, or have to dive into the keyboard shortcuts sheet to find it:

screen shot 2018-09-10 at 08 53 48

But we've actually also seen a bunch of angry users that were frustrated that it wasn't more discoverable, "because the feature was so cool".

At some point I discussed with @talldan a way to surface a tip only after you'd started pressing Tab (try this in Slack, it shows you a tip as soon as you start tabbing). That could be a neat way to do it. But until that time, perhaps it'd be good to keep this around.

@youknowriad
Copy link
Contributor Author

closing in favor of #11560

@youknowriad youknowriad closed this Nov 7, 2018
@youknowriad youknowriad deleted the try/replace-write-story-placeholderwq branch November 7, 2018 10:20
@designsimply designsimply added [Type] Enhancement A suggestion for improvement. [Type] Copy Issues or PRs that need copy editing assistance labels Dec 3, 2018
@designsimply designsimply removed the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Type] Copy Issues or PRs that need copy editing assistance [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit the "Write your story" prompt
9 participants