Adds basic Toolbar component tests. #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BE-Webdesign
added
the
[Type] Automated Testing
Closed
BE-Webdesign
force-pushed
the
add/test/components/toolbar
branch
from
f4cca21 to
425fca0
Compare
aduth
approved these changes
May 31, 2017
components/toolbar/test/index.js
Outdated
| const toolbar = shallow( <Toolbar controls={ controls } /> ); | ||
| const listItem = toolbar.find( 'IconButton' ); | ||
| expect( toolbar.type() ).to.equal( 'ul' ); | ||
| expect( listItem.props().icon ).to.equal( 'wordpress' ); |
There was a problem hiding this comment.
Minor: listItem.prop( 'icon' ) more explicit. Same goes for most of the following lines. Else we could test:
expect( listItem.props() ).to.eql( {
// ...keys
} );There was a problem hiding this comment.
Yeah, I thought I updated these, guess not lol. Will change. Should it be changed to the one command style?
expect( listItem.props() ).to.eql( {
// ...keys
} );
components/toolbar/test/index.js
Outdated
| const toolbar = shallow( <Toolbar controls={ controls } /> ); | ||
| const listItem = toolbar.find( 'IconButton' ); | ||
| listItem.simulate( 'click', { stopPropagation: () => undefined } ); | ||
| expect( clicked ).to.be.true(); |
There was a problem hiding this comment.
Sinon spies are great for this sort of test:
http://sinonjs.org/releases/v2.3.2/spies/
Appears we're now using sinon-test as of #924, so it'd be matter of:
it( 'should call the clickHandler on click.', sinon.test( function() {
const clickHandler = this.spy();
// ...
expect( clickHandler ).to.have.been.calledOnce;
} );There was a problem hiding this comment.
Yeah, I realized sinon was being used in our effects tests, so I will use that here as well in the revisions.
Adds basic Toolbar component tests. Related to progress on #641. **Testing Instructions** Run npm i && npm run test-unit ensure tests pass. Change component logic to ensure tests fail as they should.
BE-Webdesign
force-pushed
the
add/test/components/toolbar
branch
from
425fca0 to
8f5c615
Compare
Cleans up the tests to make use of spies. This also changes the `props()` convention to check whether the keys are included in the object. include is used instead of equal to ensure that the tests do not look at all props like children. Adds in a correction to the function signature of Toolbar so that the component renders properly.
BE-Webdesign
force-pushed
the
add/test/components/toolbar
branch
from
8f5c615 to
24e56e9
Compare
|
@iseulde If you could take a peek at this to make sure this aligns with the changes you made in the Toolbar component, it would be appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds basic Toolbar component tests. Related to progress on #641.
Testing Instructions
Run npm i && npm run test-unit ensure tests pass. Change component logic
to ensure tests fail as they should.