Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raAvoid changing the public API of the warning component to avoid Backwards compatibility breakage #9435

Merged
merged 1 commit into from
Aug 29, 2018
Merged

raAvoid changing the public API of the warning component to avoid Backwards compatibility breakage #9435

merged 1 commit into from
Aug 29, 2018

Conversation

youknowriad
Copy link
Contributor

closes #9431

This fixes a regression introduced in #7741 where we inadvertantly broke backwards compatibility (and other usage) of the Warning component.

I'm restoring the old name of the actions prop to fix the issue.

Testing instructions

Repeat steps from #9431
The warning should show up properly.

@youknowriad youknowriad self-assigned this Aug 29, 2018
@youknowriad youknowriad added the [Type] Bug An existing feature does not function as intended label Aug 29, 2018
johngodley
johngodley approved these changes Aug 29, 2018
View reviewed changes
Copy link
Contributor

@johngodley johngodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified all the places this is used. Thanks

aduth
aduth approved these changes Aug 29, 2018
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 I also think this is more sensible anyways, since secondaryActions is probably the rare case of usage.

@youknowriad youknowriad changed the title Avoid changing the public API of the warning component to avoid Backwards compatibility breakage raAvoid changing the public API of the warning component to avoid Backwards compatibility breakage Aug 29, 2018
@youknowriad youknowriad merged commit 5a630c2 into master Aug 29, 2018
@youknowriad youknowriad deleted the fix/warning branch August 29, 2018 16:58
@oandregal oandregal mentioned this pull request Sep 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduth aduth aduth approved these changes

@johngodley johngodley johngodley approved these changes

Assignees

@youknowriad youknowriad

Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Editor: Use-once validation and top-level error handler display no action options
3 participants
@youknowriad @johngodley @aduth