-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Columns: Disable inserter on column block; Don't show stacked icon on columns #9523
Conversation
Presumably there's already some metric which determines whether an inserter should be shown. Can that not be used in this case rather than adding an explicit support? |
c88dbf9
to
2f6c034
Compare
Hi @aduth,
In the columns, case inserter is not available because of locking being equal to all. But locking is a dynamic property specific to each InnerBlock instance. A block may even set locking prop randomly, and each instance may have a different locking. On the inserter the stacked icon refers to all the block instances, we can not rely on locking or any dynamic InnerBlocks property to decide if we should show the stacked icon in the inserter or not. We need to rely on a setting that affects all the instances like the supports, and given that we already have a supports setting for the inserter that seems our best option. |
b31395b
to
051a002
Compare
f2acc2f
to
0dda16e
Compare
f835baa
to
1d25db4
Compare
Should we change the base branch, to either |
1d25db4
to
a73dbc8
Compare
The PR #9337 was merged, so the base branch was changed and this PR now can be tested directly. |
Description
We can not use the inserter to inserter a column so the inserter should be disabled on this block.
This will also make sure the icon of the columns block does not appear stacked as in fact for the columns we don't have children that we can insert using the inserter.
Depends on: #9337
How has this been tested?
I Verified column block does not appear on the inserter, and that the columns block icon appear normally without the stacked indication.
Screenshots