This repository has been archived by the owner on Aug 4, 2023. It is now read-only.
Extract media type from staged tsv file name for loader #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tore Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
# Conflicts: # src/cc_catalog_airflow/dags/common/storage/image.py # src/cc_catalog_airflow/dags/common/storage/test_image.py
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
obulat
requested review from
zackkrida and
krysal
and removed request for
a team
zackkrida
approved these changes
Jun 24, 2021
obulat
changed the title
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
zackkrida
added
the
✨ goal: improvement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tsv_to_postgres_loaderDAG handles getting data from TSV files, saving it to S3 and intermediate database, cleaning it and finally saving the clean data to the main database.This PR adds media type (currently
image, and in the future,audio) to the tsv filename. The media type is used in the downstream tasks to use the correct functions/columns when loading the data into the database.Different tasks of the
tsv_to_postgres_loaderDAG pass the media_type data either using the filename, or, if it is not available, using the Airflow xcom messaging (xcom.push/xcom.pull).To test this PR you can:
tsv_to_postgres_loader. On its completion, you will be able to see the ingested data in openledger database.Signed-off-by: Olga Bulat obulat@gmail.comSigned-off-by: Olga Bulat obulat@gmail.com