Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Run ci on main push only #98

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Run ci on main push only #98

merged 2 commits into from
Jun 9, 2021

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Jun 9, 2021

Fixes WordPress/openverse#1733

This PR restricts GitHub actions to run on push only to the main branch to make sure that the linting and testing CI actions are not run twice.

I had used 'master' branch by mistake, and had to rename the branch because of that. Renaming a PR branch closes that PR, apparently.

Signed-off-by: Olga Bulat obulat@gmail.com

obulat added 2 commits June 9, 2021 09:08
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
@obulat obulat requested a review from a team as a code owner June 9, 2021 06:37
@obulat obulat requested review from zackkrida and dhruvkb June 9, 2021 06:37
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@obulat obulat merged commit 9942d24 into main Jun 9, 2021
@obulat obulat deleted the run_ci_on_main_push_only branch June 9, 2021 07:27
@zackkrida
Copy link
Member

FYI there is a $default-branch variable that can be used in GitHub actions, so that 'main' or 'master' doesn't have to be hardcoded.

@obulat
Copy link
Contributor Author

obulat commented Jun 9, 2021

Oh, that's great to know!

@zackkrida zackkrida added ✨ goal: improvement Improvement to an existing user-facing feature 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users and removed ✨ goal: improvement Improvement to an existing user-facing feature labels Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] CI linting and testing jobs are run twice
3 participants